Attention is currently required from: jolly, dexter.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/33548 )

Change subject: ASCI: Support conference briding with 1..n connections ......................................................................

Patch Set 2:

(4 comments)

Commit Message:

https://gerrit.osmocom.org/c/osmo-mgw/+/33548/comment/c8cef6dd_7b0eb82a PS2, Line 12: than 2 connections. please rephrase this, I don't understand: "it must be assumed that only connection receives RTP in a conference with more than 2 connections."

https://gerrit.osmocom.org/c/osmo-mgw/+/33548/comment/83fbd372_0fbfaf56 PS2, Line 15: set to (one of) the other connection that shall send out RTP. connection(s)

https://gerrit.osmocom.org/c/osmo-mgw/+/33548/comment/ea26d3cf_513ee5b4 PS2, Line 16: All connection that send RTP have "send_next" pointer set to the next connections

Patchset:

PS2: I'm a bit lost with your implementation choose here. Why having that ring buffer between connections pointing to each other instead of simply iterating over all the connections of an endpoint?

mgcp_recv(rtp) -> foreach(conn in endp) mgcp_send(rtp);