Attention is currently required from: fixeria, msuraev, osmith, pespin. lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/30094?usp=email ) Change subject: contrib/systemd: run as osmocom user ...................................................................... Patch Set 8: Code-Review-1 (2 comments) Patchset: PS8: -1: Please add a warning for the user, because you're changing something what the user doesn't expect. It would be great if you could add this to the Debian Changelog (not sure how we're generating it). File debian/postinst: https://gerrit.osmocom.org/c/osmo-mgw/+/30094/comment/51157e27_2f75374b PS8, Line 18: # Fix permissions of previous (root-owned) install (OS#4107) It would be great to show a warning or something, so the user know those file has been changed. Can't you detect if this is an upgrade and from which version you're upgrading from? -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/30094?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ibb83c231231b39dc6732c0f375aeb3b21f3938ef Gerrit-Change-Number: 30094 Gerrit-PatchSet: 8 Gerrit-Owner: msuraev <msuraev(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: msuraev <msuraev(a)sysmocom.de> Gerrit-Comment-Date: Fri, 10 May 2024 17:02:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment