[S] Change in ...pyosmocom[master]: Fixing 3-digit MNC PlmnAdapter encoding & decoding, and related tests. - gerrit-log

12 Nov 2024

Attention is currently required from: JPM, dexter.

laforge has posted comments on this change by JPM. (
https://gerrit.osmocom.org/c/python/pyosmocom/+/38687?usp=email )

Change subject: Fixing 3-digit MNC PlmnAdapter encoding & decoding, and related
tests.
......................................................................

Patch Set 5:

(1 comment)

Patchset:

PS1: 
...
  The failing tests are from project (pysim) using
pyosmocom. Those test are wrong as 3GPP TS 24. […] Agreed; we can manually override
the V+1 once the code review has reached 2.

-- 
To view, visit https://gerrit.osmocom.org/c/python/pyosmocom/+/38687?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: python/pyosmocom
Gerrit-Branch: master
Gerrit-Change-Id: I3811b227d629bd4e051a480c9622967e31f8a376
Gerrit-Change-Number: 38687
Gerrit-PatchSet: 5
Gerrit-Owner: JPM &lt;jean-pierre.marcotte.1(a)ens.etsmtl.ca&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter &lt;pmaier(a)sysmocom.de&gt;
Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-CC: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-Attention: JPM &lt;jean-pierre.marcotte.1(a)ens.etsmtl.ca&gt;
Gerrit-Attention: dexter &lt;pmaier(a)sysmocom.de&gt;
Gerrit-Comment-Date: Tue, 12 Nov 2024 12:53:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: JPM &lt;jean-pierre.marcotte.1(a)ens.etsmtl.ca&gt;