Attention is currently required from: Hoernchen, pespin.
laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/libosmocore/+/38003?usp=email )
Change subject: Fix building in environments that define _GNU_SOURCE
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
while I agree it doesn't sound good that uring is adding the define to CFLAGS instead of doing it pe […]
I also think libosmocore should be more resilient and the behaviour we want here is "make sure _GNU_SOURCE is defined" and not "define _GNU_SOURCE onl if it is not defined already and abort if it is already set".
Irrespective of that, liburing should be fixed: https://github.com/axboe/liburing/issues/1218
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/38003?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I36cb3a5555cb35ddc44f06d447268bd9cc0ce9b4
Gerrit-Change-Number: 38003
Gerrit-PatchSet: 1
Gerrit-Owner: laforge
laforge@osmocom.org
Gerrit-Reviewer: Hoernchen
ewild@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-Attention: Hoernchen
ewild@sysmocom.de
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Comment-Date: Tue, 03 Sep 2024 12:09:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hoernchen
ewild@sysmocom.de
Comment-In-Reply-To: pespin
pespin@sysmocom.de