Attention is currently required from: pespin.

osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/40006?usp=email )

Change subject: asp: Rename and clarify asp_id field ......................................................................

Patch Set 1:

(1 comment)

File src/xua_asp_fsm.c:

https://gerrit.osmocom.org/c/libosmo-sigtran/+/40006/comment/716ca9cf_8965c2... : PS1, Line 219: xua_msg_add_u32(xua, SUA_IEI_ASP_ID, asp->asp_id); the commit message only talks about renaming the field, but here the logic is changed to not send the identifier anymore in peer_send(). Probably makes sense to mention that in the commit message (or possibly split it out into a separate patch as it is a separate logical change and the commit msg is quite long already?)