Attention is currently required from: laforge, daniel.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/28939 )
Change subject: tests: Run smscb/gsm0341_test during make check
......................................................................
Patch Set 3:
(1 comment)
File tests/smscb/gsm0341_test.c:
https://gerrit.osmocom.org/c/libosmocore/+/28939/comment/e762f147_3c76a0c6
PS3, Line 40: //cbmsg = gsm0341_build_msg(NULL, 0, rand(), 0, msg_id, 0x0f, 1, 1, payload, payload_octets);
Does this need to be here?
Just leaving it there, since i don't know the original idea from whoever wrote the test. This can be extended/improved at a later point, at least we now run some test and it's not left outside of the make check.
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/28939
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Icd4feced06afb749de994195c6b338df006749ad
Gerrit-Change-Number: 28939
Gerrit-PatchSet: 3
Gerrit-Owner: pespin
pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel
dwillmann@sysmocom.de
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: daniel
dwillmann@sysmocom.de
Gerrit-Comment-Date: Fri, 05 Aug 2022 14:27:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: daniel
dwillmann@sysmocom.de
Gerrit-MessageType: comment