Attention is currently required from: arehbein, fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32073 )
Change subject: gsm_objclass2mo(): First check if TRX number is valid ......................................................................
Patch Set 2: Code-Review-1
(3 comments)
File src/common/oml.c:
https://gerrit.osmocom.org/c/osmo-bts/+/32073/comment/ca047154_611a51cb PS2, Line 1622: NM_OC_GPRS_NSVC
I am not sure if this really applies to `NM_OC_GPRS_NSVC`. […]
Ack
https://gerrit.osmocom.org/c/osmo-bts/+/32073/comment/23b55939_b79ed93d PS2, Line 1623: obj_inst->trx_nr >= bts->num_trx
`gsm_bts_trx_num()` does exactly this check internally, no need to duplicate it here.
Ack
https://gerrit.osmocom.org/c/osmo-bts/+/32073/comment/26b04f10_b6b2af0e PS2, Line 1634: case NM_OC_RADIO_CARRIER: why are these being removed?
-
pespin