Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/29551 )
Change subject: vty: 'hopping arfcn add': succeed if adding arfcn already in set ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I intentionally added this check in Ie27c859e3f16ada08a5cdc8ab4ac6e20a885a378 to facilitate finding […]
What do you mean with duplicate here? Using the command twice creates no duplicate at all in the set, so it should be totally fine. Why would you want to stop osmo-bsc from starting? because that command is set twice? that is really agressive and I see no necessity for that. Furthermore it is creating problems with apply-config-file for no good reason, so let's avoid blocking reading config files which have commands being applied twice changing no state. If at all, print some warning to make the user notice that this one was already added, so that they can see and check if they had a typo, but that's all.