Attention is currently required from: lynxis lazus.

Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39562?usp=email )

Change subject: Rework SGSN code to use new libvlr code ......................................................................

Patch Set 2:

(24 comments)

File src/sgsn/gprs_gmm.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21547): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/5e876bb9_9615685e?usp... : PS2, Line 1220: if (req.mi.type == GSM_MI_TYPE_IMSI) { braces {} are not necessary for any arm of this statement

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21547): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/7fadb321_da06420a?usp... : PS2, Line 1290: if (!mmctx->attach_rau.rau_fsm || rc != 0) { braces {} are not necessary for single statement blocks

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21547): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/2b62636e_4a77b8f7?usp... : PS2, Line 1551: else { braces {} are not necessary for single statement blocks

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21547): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/06e6a06f_9e56471e?usp... : PS2, Line 1555: if (TLVP_PRESENT(&req.tlv, GSM48_IE_GMM_PTMSI_TYPE)) { braces {} are not necessary for single statement blocks

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21547): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/e1f0ede6_41de4b71?usp... : PS2, Line 1673: if (!foreign_ra && that open brace { should be on the previous line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21547): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/ff451c77_16615e55?usp... : PS2, Line 1759: if (!strlen(mmctx->imsi) && strlen(mmctx->vsub->imsi)) { braces {} are not necessary for single statement blocks

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21547): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/8eac3fe2_7536caac?usp... : PS2, Line 1787: if (mmctx) { braces {} are not necessary for any arm of this statement

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21547): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/de998779_913ee1cc?usp... : PS2, Line 1817: if (!mmctx->attach_rau.rau_fsm || rc != 0) { braces {} are not necessary for single statement blocks

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21547): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/3606244a_48a3bcf1?usp... : PS2, Line 1964: } else { else is not generally useful after a break or return

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21547): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/fd4c448b_afb8dad6?usp... : PS2, Line 2321: if (!strlen(mmctx->imsi) && strlen(mmctx->vsub->imsi)) { braces {} are not necessary for single statement blocks

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21547): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/006b0de4_f5416c62?usp... : PS2, Line 2345: /* FIXME: when loosing the VLR subscriber, we should ensure the GMM is in IDLE (same for PMM) */ 'loosing' may be misspelled - perhaps 'losing'?

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21547): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/671f4348_5137e42f?usp... : PS2, Line 2372: if (ctx->p_tmsi != send_tmsi && ctx->p_tmsi != GSM_RESERVED_TMSI && send_tmsi != GSM_RESERVED_TMSI) that open brace { should be on the previous line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21547): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/70213992_104b6be4?usp... : PS2, Line 2387: if (ctx->attach_rau.rau_fsm) { braces {} are not necessary for single statement blocks

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21547): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/de0c8b76_db553311?usp... : PS2, Line 2393: switch(ctx->ran_type) { space required before the open parenthesis '('

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21547): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/9fb3701a_e15e9627?usp... : PS2, Line 2431: if (ctx->iu.mm_state_fsm->state == ST_PMM_CONNECTED) { braces {} are not necessary for single statement blocks

File src/sgsn/gprs_rau_fsm.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21547): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/9cf169c4_534ada1a?usp... : PS2, Line 206: switch(mmctx->ran_type) { space required before the open parenthesis '('

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21547): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/73e915fa_e02c7d3c?usp... : PS2, Line 231: switch(mmctx->ran_type) { space required before the open parenthesis '('

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21547): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/5c4279d2_892a372f?usp... : PS2, Line 304: .in_event_mask = S(GMM_RAU_E_UE_RAU_REQUEST) | S(GMM_RAU_E_VLR_RAU_ACCEPT) | S(GMM_RAU_E_VLR_RAU_REJECT) | S(GMM_RAU_E_VLR_TERM_SUCCESS)| S(GMM_RAU_E_VLR_TERM_FAIL), need consistent spacing around '|' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21547): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/2250ce2e_b9de3a19?usp... : PS2, Line 310: .in_event_mask = S(GMM_RAU_E_UE_RAU_COMPLETE) | S(GMM_RAU_E_VLR_RAU_REJECT) | S(GMM_RAU_E_VLR_RAU_ACCEPT) | S(GMM_RAU_E_UE_RAU_REQUEST) | S(GMM_RAU_E_VLR_TERM_SUCCESS)| S(GMM_RAU_E_VLR_TERM_FAIL), need consistent spacing around '|' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21547): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/db3de23e_63b0605d?usp... : PS2, Line 339: static __attribute__((constructor)) void gmm_rau_fsm_init() Bad function definition - void gmm_rau_fsm_init() should probably be void gmm_rau_fsm_init(void)

File src/sgsn/mmctx.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21547): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/4eaec78f_43d6b17b?usp... : PS2, Line 619: if (!strlen(mm->imsi) && strlen(mm->vsub->imsi)) { braces {} are not necessary for single statement blocks

File src/sgsn/sgsn_libgtp.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21547): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/eecf4f54_3289a484?usp... : PS2, Line 537: if (cause != GTPCAUSE_NON_EXIST) { braces {} are not necessary for single statement blocks

File src/sgsn/sgsn_main.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21547): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/6071f793_b6c1715e?usp... : PS2, Line 360: [DVLR] = { please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21547): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/ab36be4a_4607c6f6?usp... : PS2, Line 364: }, please, no spaces at the start of a line