Attention is currently required from: pespin, daniel.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/28935 )
Change subject: cbsp: Return error if decoding any of the cell id lists fail
......................................................................
Patch Set 2: Code-Review+2
(3 comments)
File src/gsm/cbsp.c:
https://gerrit.osmocom.org/c/libosmocore/+/28935/comment/48dc53f0_b49edc57
PS1, Line 661: TLVP_LEN(tp, CBSP_IEI_CELL_LIST));
cosmetic: alignment (here and below)
Done
https://gerrit.osmocom.org/c/libosmocore/+/28935/comment/207ab9aa_634580f1
PS1, Line 959: cbsp_decode_loading_list(&out->loading_list, ctx,
Check for failure here as well?
Done
https://gerrit.osmocom.org/c/libosmocore/+/28935/comment/8e81ec55_46055334
PS1, Line 990: cbsp_decode_loading_list(&out->loading_list, ctx,
And here
Done
--
To view, visit
https://gerrit.osmocom.org/c/libosmocore/+/28935
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I5934167f927df0547cb57687e2717489fd1f3719
Gerrit-Change-Number: 28935
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 05 Aug 2022 13:24:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>
Gerrit-MessageType: comment