Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/31773 ) Change subject: tests: move '-I$(top_srcdir)/include/' to AM_CPPFLAGS ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: I think it's totally fine to have -I in CFLAGS. They main difference is that CPPFLAGS is included in both C++ and C files, while CFLAGS is only included in C files. -- To view, visit https://gerrit.osmocom.org/c/libosmo-gprs/+/31773 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-gprs Gerrit-Branch: master Gerrit-Change-Id: Ic3e3dc75789850d2884d3e757f05ff01e136a5f4 Gerrit-Change-Number: 31773 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 09 Mar 2023 09:51:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment