Attention is currently required from: arehbein. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34868?usp=email ) Change subject: neighbor_ident: Use ctrl_interface_setup2() instead of ctrl_interface_setup_dynip2() (deprecated) ...................................................................... Patch Set 1: Code-Review-1 (1 comment) File src/osmo-bsc/neighbor_ident.c: https://gerrit.osmocom.org/c/osmo-bsc/+/34868/comment/0bb11b16_9ff29e0e PS1, Line 492: return ctrl_interface_setup2(net, net->neigh_ctrl.port, NULL, _LAST_CTRL_NODE_NEIGHBOR); I'm not sure this is correct, because this is a separate CTRL interface with specific needs (now deprecated). With this patch you would be applying the same IP address as for the general CTRL interface, which is unexpected here. I don't see net->neigh_ctrl.addr being passed here. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/34868?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I612401b5bac5650e65d3bb4df09fd0310175ffa6 Gerrit-Change-Number: 34868 Gerrit-PatchSet: 1 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: msuraev <msuraev(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Comment-Date: Mon, 23 Oct 2023 14:54:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment