Attention is currently required from: arehbein.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34868?usp=email )

Change subject: neighbor_ident: Use ctrl_interface_setup2() instead of ctrl_interface_setup_dynip2() (deprecated) ......................................................................

Patch Set 1: Code-Review-1

(1 comment)

File src/osmo-bsc/neighbor_ident.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/34868/comment/0bb11b16_9ff29e0e PS1, Line 492: return ctrl_interface_setup2(net, net->neigh_ctrl.port, NULL, _LAST_CTRL_NODE_NEIGHBOR); I'm not sure this is correct, because this is a separate CTRL interface with specific needs (now deprecated).

With this patch you would be applying the same IP address as for the general CTRL interface, which is unexpected here. I don't see net->neigh_ctrl.addr being passed here.