Attention is currently required from: arehbein.

Patch set 1:Code-Review -1

View Change

1 comment:

• File src/osmo-bsc/neighbor_ident.c:

  • Patch Set #1, Line 492: return ctrl_interface_setup2(net, net->neigh_ctrl.port, NULL, _LAST_CTRL_NODE_NEIGHBOR);

    I'm not sure this is correct, because this is a separate CTRL interface with specific needs (now deprecated).

    With this patch you would be applying the same IP address as for the general CTRL interface, which is unexpected here. I don't see net->neigh_ctrl.addr being passed here.

To view, visit change 34868. To unsubscribe, or for help writing mail filters, visit settings.