Attention is currently required from: fixeria, lynxis lazus, osmith.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34778?usp=email )
Change subject: Introduce EPDG_Tests testsuite ......................................................................
Patch Set 6:
(2 comments)
File epdg/EPDG_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34778/comment/13abdc4f_cb402... PS6, Line 231: /* TODO: maybe use, set to true */
kept intentionally?
the comment? yes, it's for next stages.
File library/DIAMETER_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34778/comment/ce02fb50_9b7f3... PS6, Line 2295: //tr_AVP_3GPP_IntegrityKey(?) /* Optional */
do you want to keep the // lines in addition to the TODO comment below?
I think it's fine for now, it helps people find the related templates/types.
-
pespin