Attention is currently required from: pespin.
Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41878?usp=email )
Change subject: build: move netns/tun conditionals to configure.ac Move Linux-/embedded-specific conditional compilation out of the sources and into configure.ac. ......................................................................
Patch Set 1:
(1 comment)
File configure.ac:
https://gerrit.osmocom.org/c/libosmocore/+/41878/comment/0ce0dba1_9ef31925?u... : PS1, Line 242: AM_CONDITIONAL(ENABLE_TUN, test "x$embedded" != "xyes")
In this patch, ENABLE_TUN is a noop, so it doesn't make sense to have a patch containing that imho. […]
Agreed. I'll drop ENABLE_TUN from this patch and just use !EMBEDDED.
For Emscripten I'll add a proper configure-time capability check for the actual tun.c dependency and exclude it only when that check fails.