Attention is currently required from: falconia.

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/37287?usp=email )

Change subject: trau_rtp_conv: add support for HRv1 in 8k format ......................................................................

Patch Set 2: Code-Review+1

(2 comments)

File src/trau/trau_rtp_conv.c:

https://gerrit.osmocom.org/c/libosmo-abis/+/37287/comment/fb5f8523_89cca9f6 PS2, Line 258: if (xc_bits[i]) : sum++; Can we do `sum += xc_bits[i]` here? Theoretically, this should be better in terms of performance. But we need to be sure that `xc_bits[i]` is either 0 or 1, otherwise the logic is wrong. Alternatively: `sum += (xc_bits[i] > 0)`.

https://gerrit.osmocom.org/c/libosmo-abis/+/37287/comment/bf268b54_74af4765 PS2, Line 669: tf->xc_bits[0] = 0; cosmetic: maybe use designated initializers to make it shorter / more readable?

``` if (osmo_hr_check_sid(data, data_len)) tf->xc_bits = { [3] = 1 }; else tf->xc_bits = { [5] = 1 }; ```

Not critical, you can keep it as-is.