Attention is currently required from: fixeria.

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42520?usp=email )

Change subject: stp: STP_Tests_IPA: Introduce tests TC_ipa_tcp_{cli,srv}_adm_shutdown ......................................................................

Patch Set 1:

(2 comments)

File stp/STP_Tests_IPA.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42520/comment/801b36b2_f6b47... : PS1, Line 209: //if (not g_ipa_configs[i].is_server) {

Maybe add a comment explaining why the if is commented out?

Done

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42520/comment/f87e065c_4b96f... : PS1, Line 230: f_listen_ipa

I am not strictly against abusing this function, but IMO a separate function with a self-explaining […]

Done