Attention is currently required from: fixeria.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32266 )
Change subject: bts: Proper tear down
......................................................................
Patch Set 2:
(1 comment)
File bts/BTS_Tests_OML.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32266/comment/84a7c737_cba5…
PS1, Line 155: f_shutdown_helper
My suggestion was to use `Misc_Helpers. f_shutdown()`
directly. […]
I prefer using a local wrapper so that we don't need to change
lots of tests afterwards if more stuff needs to be added. Lots of testsuites have local
wrappers so it's not strange.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/32266
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I761ae94aa698a74bb30b8a6b1860358545f222b5
Gerrit-Change-Number: 32266
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 11 Apr 2023 14:04:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment