Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27470 ) Change subject: bsc_nat_sccp_inst: local_sccp_addr -> addr ...................................................................... Patch Set 1: (1 comment) File include/osmocom/bsc_nat/bsc_nat.h: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27470/comment/7ff1501e_d827ec2d PS1, Line 28: struct osmo_sccp_addr addr; /* OsmoBSCNAT's local address */ Maybe loc_addr or local_addr would be more intuitive when reading code. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27470 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc-nat Gerrit-Branch: master Gerrit-Change-Id: I3083374d589487ed960507e7a431c45914afc5dd Gerrit-Change-Number: 27470 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Thu, 10 Mar 2022 15:05:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment