Attention is currently required from: pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-pcu/+/30575 )
Change subject: Convert ms_first_common_ts to struct gprs_rlcmac_pdch
......................................................................
Patch Set 2:
(2 comments)
File src/gprs_ms.h:
https://gerrit.osmocom.org/c/osmo-pcu/+/30575/comment/4b159c34_cb459933
PS2, Line 68: _ts
How about renaming s/_ts/_pdch/ to make the type of this field cleaner?
https://gerrit.osmocom.org/c/osmo-pcu/+/30575/comment/28cd226a_c41dcc9d
PS2, Line 106: _ts
Same here, s/_ts/_pdch/.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-pcu/+/30575
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I19373939ec104d371e3e91422f018a8175cb0f89
Gerrit-Change-Number: 30575
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 15 Dec 2022 21:37:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment