Attention is currently required from: fixeria, pespin, dexter.
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/27608 )
Change subject: mgcp_network: log RTP/RTCP reception failures
......................................................................
Patch Set 3:
(1 comment)
File src/libosmo-mgcp/mgcp_network.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/27608/comment/0c491a23_58717088
PS1, Line 1515: if (rc < 0) {
Ack
indeed, we need specific information what has failed (in the code where that failure is detected) rather than some generic statement that "something" has failed. Also, keep in mind that RTP packets occur at high rates and we always have to be careful not to overload logs with tons of stuff.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-mgw/+/27608
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Ic0e60fe2fb9d96b8ae18bb862b5715359a10e849
Gerrit-Change-Number: 27608
Gerrit-PatchSet: 3
Gerrit-Owner: dexter
pmaier@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-CC: laforge
laforge@osmocom.org
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Attention: pespin
pespin@sysmocom.de
Gerrit-Attention: dexter
pmaier@sysmocom.de
Gerrit-Comment-Date: Sat, 16 Apr 2022 08:47:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria
vyanitskiy@sysmocom.de
Comment-In-Reply-To: pespin
pespin@sysmocom.de
Gerrit-MessageType: comment
laforge