Attention is currently required from: dexter.
msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/30635 )
Change subject: cards: check length of mnc more restrictively
......................................................................
Patch Set 1:
(1 comment)
File pySim/cards.py:
https://gerrit.osmocom.org/c/pysim/+/30635/comment/34546a71_77b5c851
PS1, Line 213: raise RuntimeError('invalid length of mnc "{}"'.format(mnc))
It would be handy to also print what exactly we consider valid length in here.
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/30635
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Iee8f25416e0cc3be96dff025affb1dc11d919fcd
Gerrit-Change-Number: 30635
Gerrit-PatchSet: 1
Gerrit-Owner: dexter
pmaier@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-CC: msuraev
msuraev@sysmocom.de
Gerrit-Attention: dexter
pmaier@sysmocom.de
Gerrit-Comment-Date: Sun, 18 Dec 2022 14:05:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment