fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/42382?usp=email )
Change subject: ota: OtaAlgo{Crypt,Auth}: fix algo_auth vs algo_crypt ......................................................................
ota: OtaAlgo{Crypt,Auth}: fix algo_auth vs algo_crypt
* OtaAlgoCrypt.from_keyset() searches by `otak.algo_crypt` but the error message prints `otak.algo_auth`. Should be `otak.algo_crypt` instead.
* OtaAlgoAuth.__init__() checks `algo_auth` but the error message prints `algo_crypt`. Should be `otak.algo_auth` instead.
Change-Id: Ia636fffaeadc68e3f6d5b65d477e753834c95895 --- M pySim/ota.py 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/82/42382/1
diff --git a/pySim/ota.py b/pySim/ota.py index fbb9d45..3d2da15 100644 --- a/pySim/ota.py +++ b/pySim/ota.py @@ -221,12 +221,12 @@ for subc in cls.__subclasses__(): if subc.enum_name == otak.algo_crypt: return subc(otak) - raise ValueError('No implementation for crypt algorithm %s' % otak.algo_auth) + raise ValueError('No implementation for crypt algorithm %s' % otak.algo_crypt)
class OtaAlgoAuth(OtaAlgo, abc.ABC): def __init__(self, otak: OtaKeyset): if self.enum_name != otak.algo_auth: - raise ValueError('Cannot use algorithm %s with key for %s' % (self.enum_name, otak.algo_crypt)) + raise ValueError('Cannot use algorithm %s with key for %s' % (self.enum_name, otak.algo_auth)) super().__init__(otak)
def sign(self, data:bytes) -> bytes:
-
fixeria