Attention is currently required from: dexter, lynxis lazus.

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/34884?usp=email )

Change subject: pySim-shell: don't get trapped in applications without file system ......................................................................

Patch Set 2:

(2 comments)

File pySim-shell.py:

https://gerrit.osmocom.org/c/pysim/+/34884/comment/fa20ae0b_4cf8a39c PS2, Line 618: # you're mixing python-style space indent with tabs here. Please avoid tabs in python source.

https://gerrit.osmocom.org/c/pysim/+/34884/comment/b07c7cba_3a1d3268 PS2, Line 620: "a0000000871002", "a0000000871004"]: I like the approach in general, but I think we shouldn't open-code those AIDs explicitly here. We should have defined those somewhere. Also, always keep in mind that not all cards support select-by-aid with partial AID. This is why we have code that first expands it via EF.DIR in UiccCardBase.select_adf_by_aid. Also, the list is incomplete as (at least) ADF.HPSIM would behave identical to ADF.USIM/ISIM.