Attention is currently required from: dexter, lynxis lazus.
2 comments:
File pySim-shell.py:
you're mixing python-style space indent with tabs here. Please avoid tabs in python source.
Patch Set #2, Line 620: "a0000000871002", "a0000000871004"]:
I like the approach in general, but I think we shouldn't open-code those AIDs explicitly here. We should have defined those somewhere. Also, always keep in mind that not all cards support select-by-aid with partial AID. This is why we have code that first expands it via EF.DIR in UiccCardBase.select_adf_by_aid. Also, the list is incomplete as (at least) ADF.HPSIM would behave identical to ADF.USIM/ISIM.
To view, visit change 34884. To unsubscribe, or for help writing mail filters, visit settings.