Attention is currently required from: fixeria, laforge.

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41702?usp=email )

Change subject: logging_vty: Allow setting gsmtap log tgt as (blocking-io|nonblocking-io|wq) ......................................................................

Patch Set 2:

(3 comments)

File src/core/gsmtap_util.c:

https://gerrit.osmocom.org/c/libosmocore/+/41702/comment/3ea3d713_209562ad?u... : PS2, Line 428: int on

missing docstring

Done

File src/vty/logging_vty.c:

https://gerrit.osmocom.org/c/libosmocore/+/41702/comment/b754528a_6a3db020?u... : PS2, Line 818: "Use non-blocking, synchronous I/O (may lose msgs if UDP sndbuf becomes full)\n"

s/sndbuf/socket transmit buffer/ or s/sndbuf/socket send buffer/ ?

Done

https://gerrit.osmocom.org/c/libosmocore/+/41702/comment/b778b5d4_1167633f?u... : PS2, Line 831: ofd_wq_mode ? 1 : 0,

A boolean is expected here, why do you convert it to an integer?

Done