Attention is currently required from: fixeria.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34310?usp=email )
Change subject: l1gprs/l1ctl: Decouple RTS.ind from DL_BLOCK.ind ......................................................................
Patch Set 1:
(6 comments)
File src/host/layer23/src/common/l1ctl.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/34310/comment/fe78ac36_e95263e3 PS1, Line 1007: Rx GPRS DL block
copy-paste, `Rx GPRS RTS. […]
Ack
File src/host/layer23/src/modem/grr.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/34310/comment/683d78c3_5a202369 PS1, Line 480: Do not send RTS.ind if we got PTCCH/D
l1gprs should be smart enough to not send RTS. […]
Ack
File src/host/trxcon/src/trxcon_fsm.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/34310/comment/ba029f6d_35032bf4 PS1, Line 634: /* Every fn % 13 == 12 we have either a PTCCH or an IDLE slot, thus
cosmetic: comment alignment
Ack
File src/host/virt_phy/src/virt_prim_pdch.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/34310/comment/7557d4dc_b8f24a66 PS1, Line 79: usf
You need to assign `0xff` by default, because `l1gprs_handle_dl_block_ind()` may return early.
Ack
https://gerrit.osmocom.org/c/osmocom-bb/+/34310/comment/17ff0b24_0fc27709 PS1, Line 101: /* Every fn % 13 == 12 we have either a PTCCH or an IDLE slot, thus
cosmetic: comment alignment
Ack
File src/shared/l1gprs.c:
https://gerrit.osmocom.org/c/osmocom-bb/+/34310/comment/905c7258_77e72e6c PS1, Line 699: l1gprs_check_pending_tbfs
Just to be sure, is it ok that we still call it here?
I'd say it's fine, since it's only 1 block difference so it shouldn't do strange stuff when comparing FNs.
In the end we probably need to improve all this to have a different state for Rx and Tx (RTS.ind), but this patch improves the overall situation so far. We can later improve further.
-
pespin