Attention is currently required from: pespin, dexter.

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/33522 )

Change subject: pcu_sock: use PCUIF version 11 (direct TLLI) ......................................................................

Patch Set 1:

(1 comment)

File src/common/pcu_sock.c:

https://gerrit.osmocom.org/c/osmo-bts/+/33522/comment/70aad5e5_eb5edbe2 PS1, Line 635: pcu_prim->u.data_cnf_dt = (struct gsm_pcu_if_data_cnf_dt) {

iiuc this makes osmo-bts defacto only use the new SAPI, and hence only work properly against an osmo-pcu using/supporting PCUIF 11.

This has always been the case when bumping the PCUIF protocol version.

IMHO, osmo-bts should store info on which SAPI was used to send the PDH_DATA.req and then use thew old or new SAPI based on that, to stay compatible against older osmo-pcu.

IMO, this is unnecessary complication. I would even go for removing the old TLLI-less messages/structures completely and having only the PCUIFv11 stuff in osmo-bts.git, while keeping backwards compatibility in osmo-pcu.git. It's the first time we're aiming to stay backwards compatible, and see how many weeks it's already taking too finish this. Let's avoid complicating/delaying it even further.