[M] Change in osmo-bsc[master]: SCCP N-PCSTATE: trigger MSC status on PC availability - gerrit-log

5 Apr 2023


      Attention is currently required from: neels, laforge.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/32151 )
Change subject: SCCP N-PCSTATE: trigger MSC status on PC availability
......................................................................
Patch Set 3:
(1 comment)
File src/osmo-bsc/osmo_bsc_sigtran.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/32151/comment/88ee2f42_8a1e6b87 
PS3, Line 224: 	connected = false;
I find all this pretty confusing. Cannot you have different connected_* variable and then a final merged "connected" one?
Having "connected" and "disconnected" in different variables feels like Schrödinger cat. Can it happen that (connected && disconnected) == true?
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/32151
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I3a0869598b8395601a16d78dbc46eec400c0ea84
Gerrit-Change-Number: 32151
Gerrit-PatchSet: 3
Gerrit-Owner: neels nhofmeyr@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge laforge@osmocom.org
Gerrit-CC: pespin pespin@sysmocom.de
Gerrit-Attention: neels nhofmeyr@sysmocom.de
Gerrit-Attention: laforge laforge@osmocom.org
Gerrit-Comment-Date: Wed, 05 Apr 2023 14:39:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment