Attention is currently required from: Hoernchen. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30610 ) Change subject: logging: rework the macros ...................................................................... Patch Set 1: Code-Review-1 (1 comment) File src/logging.c: https://gerrit.osmocom.org/c/libosmocore/+/30610/comment/7804f198_7676e6c9 PS1, Line 778: if (tall_log_ctx == NULL) { There was a 'break' in the macro, so that either the fallback or the normal logic is executed. Now you're changing the flow to execute both fallback or the normal logic if tall_log_ctx is NULL. This is wrong. You need to do 'else if' here to avoid executing both. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30610 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I03efa954cb9e991d2c3da4b61b12aac651e0efa2 Gerrit-Change-Number: 30610 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Dec 2022 01:34:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment