Attention is currently required from: arehbein, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/32354 ) Change subject: gsm_objclass2obj(): Change signature/set NACK cause ...................................................................... Patch Set 2: (2 comments) File src/common/oml.c: https://gerrit.osmocom.org/c/osmo-bts/+/32354/comment/a5be9d45_37bf991d PS2, Line 537: enum abis_nm_nack_cause c; This should be in the previous commit. https://gerrit.osmocom.org/c/osmo-bts/+/32354/comment/3a954629_b6355056 PS2, Line 1106: gsm_objclass2obj Ack. On the other hand, if one fails the other should fail the same too, so no big problem in practice. BUt yeah, let's check it wice anyway to be more clear. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/32354 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: If734ea2c8cae4c1f99b02520dffa4e3862a67745 Gerrit-Change-Number: 32354 Gerrit-PatchSet: 2 Gerrit-Owner: arehbein <arehbein(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: arehbein <arehbein(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 19 Apr 2023 11:06:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment