laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34427?usp=email ) Change subject: gsm_12_21.h: fix values for NM_IPAC_F_GPRS_CODING_MCS[1-9] ...................................................................... gsm_12_21.h: fix values for NM_IPAC_F_GPRS_CODING_MCS[1-9] The MCS9 actually goes to the first octet, MCS1..8 fill the second one. Change-Id: I85316af9b57e8113077305798cb2d82a24e48e00 Fixes: a7d7cf28 "gsm_12_21.h: add flags for NM_ATT_IPACC_SUPP_FEATURES" Related: OS#4505 --- M include/osmocom/gsm/protocol/gsm_12_21.h 1 file changed, 9 insertions(+), 9 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/include/osmocom/gsm/protocol/gsm_12_21.h b/include/osmocom/gsm/protocol/gsm_12_21.h index 39b1d45..ff10b07 100644 --- a/include/osmocom/gsm/protocol/gsm_12_21.h +++ b/include/osmocom/gsm/protocol/gsm_12_21.h @@ -835,15 +835,15 @@ #define NM_IPAC_F_GPRS_CODING_CS3 (1 << 2) #define NM_IPAC_F_GPRS_CODING_CS4 (1 << 3) /*! ip.access support flags for NM_IPAC_EIE_GPRS_CODING (EGPRS) */ -#define NM_IPAC_F_GPRS_CODING_MCS1 (1 << 7) -#define NM_IPAC_F_GPRS_CODING_MCS2 (1 << 8) -#define NM_IPAC_F_GPRS_CODING_MCS3 (1 << 9) -#define NM_IPAC_F_GPRS_CODING_MCS4 (1 << 10) -#define NM_IPAC_F_GPRS_CODING_MCS5 (1 << 11) -#define NM_IPAC_F_GPRS_CODING_MCS6 (1 << 12) -#define NM_IPAC_F_GPRS_CODING_MCS7 (1 << 13) -#define NM_IPAC_F_GPRS_CODING_MCS8 (1 << 14) -#define NM_IPAC_F_GPRS_CODING_MCS9 (1 << 15) +#define NM_IPAC_F_GPRS_CODING_MCS1 (1 << 8) +#define NM_IPAC_F_GPRS_CODING_MCS2 (1 << 9) +#define NM_IPAC_F_GPRS_CODING_MCS3 (1 << 10) +#define NM_IPAC_F_GPRS_CODING_MCS4 (1 << 11) +#define NM_IPAC_F_GPRS_CODING_MCS5 (1 << 12) +#define NM_IPAC_F_GPRS_CODING_MCS6 (1 << 13) +#define NM_IPAC_F_GPRS_CODING_MCS7 (1 << 14) +#define NM_IPAC_F_GPRS_CODING_MCS8 (1 << 15) +#define NM_IPAC_F_GPRS_CODING_MCS9 (1 << 7) /*! ip.access support flags for NM_IPAC_EIE_RTP_FEATURES */ #define NM_IPAC_F_RTP_FEAT_COMPR_CONTROL (1 << 0) /* RTP Compression Control */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34427?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I85316af9b57e8113077305798cb2d82a24e48e00 Gerrit-Change-Number: 34427 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt;