Attention is currently required from: osmith, daniel.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-gprs/+/29114 )
Change subject: contrib/libosmo-gprs.spec.in: properly define RPM packages
......................................................................
Patch Set 6:
(2 comments)
File contrib/libosmo-gprs.spec.in:
https://gerrit.osmocom.org/c/libosmo-gprs/+/29114/comment/0108be17_7f9bfcc5
PS2, Line 72: --includedir="%_includedir/%name"
removing --enable-shared works, but apparently
--disable-static is not the default. […]
Good to know, thanks!
https://gerrit.osmocom.org/c/libosmo-gprs/+/29114/comment/ed6004f6_6c544183
PS2, Line 77: find "%buildroot/%_libdir" -type f -name "*.la" -delete
the rpm build actually fails if there are additional
files
This is weird, but not that important. Marking as resolved.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-gprs/+/29114
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I9be45c43ba3e342e1dba4b60561880c00841f549
Gerrit-Change-Number: 29114
Gerrit-PatchSet: 6
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 18 Aug 2022 08:57:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment