Attention is currently required from: msuraev. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/29671 )
Change subject: jobs/gerrit-verifications: write summary comment ......................................................................
Patch Set 1:
(2 comments)
File jobs/gerrit-pipeline-result.yml:
https://gerrit.osmocom.org/c/osmo-ci/+/29671/comment/9af27be5_0067d052 PS1, Line 12: node: osmocom-gerrit-debian10 || osmocom-gerrit-debian11
What's the reason for using Debian 10? I though the plan is to migrate everything we can to Debian 1 […]
see discussion here: https://gerrit.osmocom.org/c/osmo-ci/+/29604/4/jobs/gerrit-binpkgs.yml#16
File scripts/jenkins-gerrit/pipeline_summary.py:
https://gerrit.osmocom.org/c/osmo-ci/+/29671/comment/f24a5859_d900f14b PS1, Line 174: def main():
Why extra function? You can just move it directly below where main() is called.
It's a convention used often in python code, and personally I think it looks better than just writing the code below the if. But functionally it would be the same.