Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34423?usp=email ) Change subject: ASCI: Ignore LAPD frames from MS, while the uplink is not active ...................................................................... Patch Set 2: (3 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-bts/+/34423/comment/b7791f22_2bac9f9e PS2, Line 12: these frames is not desired and not required. If we react on them, we "A reaction of LAPD is to these frames" ^ makes no sense, please rephrase. File src/common/l1sap.c: https://gerrit.osmocom.org/c/osmo-bts/+/34423/comment/bafeba6d_b2281148 PS2, Line 1817: /* Do not forward any message from the MS to LAPD while the uplink is not This "MS to LAPD" direction description is not really clear to me. Can you find a better term or decription? https://gerrit.osmocom.org/c/osmo-bts/+/34423/comment/7b13aadc_c0ef7cd5 PS2, Line 1820: * these frames is not desired and not required. If we react on them, we "A reaction of LAPD is to these frames" ^ again, makes no sense. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34423?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5075115123055b2997481f56ddf473430a1dc9e3 Gerrit-Change-Number: 34423 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 19 Sep 2023 10:42:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment