Attention is currently required from: fixeria, lynxis lazus, pespin.

dotsimon has posted comments on this change by dotsimon. ( https://gerrit.osmocom.org/c/osmo-msc/+/39428?usp=email )

Change subject: include SM-RP-UI in outgoing GSUP message when presesnt ......................................................................

Patch Set 2:

(1 comment)

File src/libmsc/gsm_04_11_gsup.c:

https://gerrit.osmocom.org/c/osmo-msc/+/39428/comment/7280c984_7c5288cf?usp=... : PS2, Line 187: int gsm411_gsup_mt_fwd_sm_res(struct gsm_trans *trans, uint8_t sm_rp_mr, uint8_t *ui)

I'd say better pass the len as a separate param here, and pass the buffer as &(ui[1])

Ok sure. I'd already been thinking about further validating the length since fuzzing open mobile implementations has been in the news lately, so I'll add that too.