Attention is currently required from: fixeria.
laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/pysim/+/33693
)
Change subject: create pySim.legacy.ts_51_011.py and move legacy code there
......................................................................
Patch Set 4:
(2 comments)
File pySim/legacy/ts_51_011.py:
https://gerrit.osmocom.org/c/pysim/+/33693/comment/c7110a12_4a5bf4cd
PS3, Line 3: # without this, pylint will fail when inner classes are used
: # within the 'nested' kwarg of our TlvMeta metaclass on python 3.7
:(
: # pylint
This is not needed here anymore.
Done
https://gerrit.osmocom.org/c/pysim/+/33693/comment/bd170e1a_9b6c9f8c
PS3, Line 7: """ Various constants from 3GPP TS 51.011 used by *legacy*
code only.
the point is that nobody should use those incomplete
data types here anymore. […]
Done
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/33693
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I20ceea3fdb02ee70d8c8889c078b2e5a0f17c83b
Gerrit-Change-Number: 33693
Gerrit-PatchSet: 4
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 12 Jul 2023 19:43:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment