Change in libosmocore[master]: comments: gsm_08_08.h: AMR cfg: explain in much more detail - gerrit-log

23 Sep 2022


      Attention is currently required from: neels.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/29472 )
Change subject: comments: gsm_08_08.h: AMR cfg: explain in much more detail
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File include/osmocom/gsm/protocol/gsm_08_08.h:
https://gerrit.osmocom.org/c/libosmocore/+/29472/comment/532e27db_2e982e94 
PS1, Line 639:  * Set bit Sn (S0 -> 0x01), where Sn is identified by a descriptive name.
"S0 = 0x01". I first thought it was some sort of range with the "->".
-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/29472
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I1864a6beeeedc301c6dc7e2e0c52a3f94b2fef01
Gerrit-Change-Number: 29472
Gerrit-PatchSet: 1
Gerrit-Owner: neels nhofmeyr@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-Attention: neels nhofmeyr@sysmocom.de
Gerrit-Comment-Date: Fri, 23 Sep 2022 17:08:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment