Attention is currently required from: laforge, osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/38698?usp=email ) Change subject: old-tags-against-master: ignore last osmo-bsc tags ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: It's simple: I already fixed all users of libosmo-sigtran to avoid using structs. Hence, structs can finally (it should have been like that since the start) be made private. This means I can now modify structs inside the library, which will be needed to implement AS loadsharing. This also means anyone, in the future, can add new features without breaking ABI/API again. So, imho, here we can accept that broken user code accessing structs is not going to build with newer versions of the library without applying a small patchset (already available in master and/or gerrit), or keep breaking ABI again and again because we don't want to fix the root problem, also in the process making my time 10x times more difficult to implement the features. I'm the first one willing to keep ABI stable, but if we want to do that then we need to reasonable and stop making tons of stuff public-first before there's even a known user of those APIs/structs. Otherwise all this is nonsense imho. BTW, this is still happening with newer libraries like libosmo-pfcp, despite I think I'm raising the topic at review time here and there. -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/38698?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Iac7e6ea7815dd2c3eb9c2636c0caa661161654ed Gerrit-Change-Number: 38698 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sun, 10 Nov 2024 22:24:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>