Attention is currently required from: laforge, dexter.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33898 )
Change subject: S1AP_Emulation: improve accessibility of unit-data
......................................................................
Patch Set 4:
(1 comment)
File library/S1AP_Emulation.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33898/comment/10da5150_3d78a...
PS4, Line 389: return S1apExpectTableProc[i].vc_conn;
you are assuming only 1 vc_conn may register a given procedure code. Instead you should send message to all matching ones.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33898
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I041b45b247e365b0d4ee8645c07dc5f26007af82
Gerrit-Change-Number: 33898
Gerrit-PatchSet: 4
Gerrit-Owner: dexter
pmaier@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: pespin
pespin@sysmocom.de
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: dexter
pmaier@sysmocom.de
Gerrit-Comment-Date: Mon, 24 Jul 2023 18:46:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment