Attention is currently required from: osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/30088 )
Change subject: asn1tostruct: fix defines getting redefined ......................................................................
Patch Set 3:
(2 comments)
Patchset:
PS3: So you seem to fix some code generation in this patch, but I don't see any .c/.h files changes. Is that because the as1nstruct is called dynamically during build time?
File asn1/utils/asn1tostruct.py:
https://gerrit.osmocom.org/c/osmo-iuh/+/30088/comment/f67e31ea_1fa3837a PS3, Line 84: use the same type multiple times, in that case we use the actual name Did you think about simply adding a suffix to it? like a counter if count != 1?
-
pespin