Attention is currently required from: pespin.
dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-mgw/+/27223
)
Change subject: mgcp_codec: do not differntiate between oe and bwe when comparing codec
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-mgw/+/27223/comment/52f5d6d1_e48a4a5f
PS1, Line 12: return true (=equel).
equal
Done
File src/libosmo-mgcp/mgcp_codec.c:
https://gerrit.osmocom.org/c/osmo-mgw/+/27223/comment/8ee1d669_3bcadb8c
PS1, Line 382: /* Note: AMR allows to set the RTP payload format to octet-aligned or
bandwith-efficient (octet-aligned=0)
So does that mean that one cannot configure 2
different codecs, each with a different PT, one contai […]
At least not as far as
the payload type conversion is concerned. The patch basically reverts
Ib8be73a7ca1b95ce794d130e8eb206dcee700124. I don't have any background. Also
codecs_same is only used by mgcp_codec_pt_translate, I don't think that we will get
into trouble when we change this.
(unfortunately this is pressing)
--
To view, visit
https://gerrit.osmocom.org/c/osmo-mgw/+/27223
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I64731570c287a75d39c79c10e1bc09a37bdd54d6
Gerrit-Change-Number: 27223
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 16 Feb 2022 11:46:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment