Attention is currently required from: arehbein.

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33197 )

Change subject: stream: Add server-side (segmentation) support for IPAC ......................................................................

Patch Set 1:

(2 comments)

File include/osmocom/netif/stream.h:

https://gerrit.osmocom.org/c/libosmo-netif/+/33197/comment/f5e19aca_f72b17e4 PS1, Line 25: osmo_stream_proto The naming is unfortunately not good, IMHO. The *protocol* in terms of a socket has a well-defined meaning as something like TCP, UDP, SCTP, UDP-LITE, DCCP, ...

what about osmo_stream_segmentation instead?

https://gerrit.osmocom.org/c/libosmo-netif/+/33197/comment/89e97b4d_7d47bd4a PS1, Line 28: /* TODO: Add protocols for I don't think there are any others, so it's not a TODO. It's only if at some theoretical future point somebody adds such a protocol, they should do it here. So let's remove the TODO from the comment, please. Otherwise it looks like in general we still are missing some functionality here.