[S] Change in osmo-ttcn3-hacks[master]: library/s1ap: comment out optional IE in tr_S1AP_InitialCtxSetupResp - gerrit-log

26 Sep 2024

Attention is currently required from: fixeria, laforge.

pespin has posted comments on this change by fixeria. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38277?usp=email )

Change subject: library/s1ap: comment out optional IE in tr_S1AP_InitialCtxSetupResp
......................................................................

Patch Set 1: Code-Review+1

(2 comments)

File library/s1ap/S1AP_Templates.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38277/comment/e4334a6f_f62b…
:
PS1, Line 734: 					/*, {
...
  > what's wrong with sending this? You are not
explaining why. […] Acknowledged

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38277/comment/6331b039_7e47…
:
PS1, Line 755: 				protocolIEs := {
...
  `superset()` removes the need to put the `*` at the
end (which was there before my patches). […] Acknowledged

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38277?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I4765036be69ff10adb8c510d4092834c4e923229
Gerrit-Change-Number: 38277
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Attention: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-Attention: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-Comment-Date: Thu, 26 Sep 2024 14:07:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Comment-In-Reply-To: pespin &lt;pespin(a)sysmocom.de&gt;