Attention is currently required from: pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/33811 )
Change subject: sm: Handle GMMSM-MODIFY.ind primitive ......................................................................
Patch Set 6:
(2 comments)
File include/osmocom/gprs/sm/sm_private.h:
https://gerrit.osmocom.org/c/libosmo-gprs/+/33811/comment/e6045034_aa105b0b PS6, Line 159: struct osmo_gprs_sm_prim *gprs_sm_prim_alloc_smreg_pdp_deact_ind(void); should everything about deact_ind go into a separate patch? or how does it relate to GMMSM-MODIFY.ind?
File src/sm/sm_prim.c:
https://gerrit.osmocom.org/c/libosmo-gprs/+/33811/comment/d68da27d_3ea25019 PS6, Line 603: */ did you leave this and the TODO below intentionally?