Attention is currently required from: daniel, neels.

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39239?usp=email )

Change subject: mgw: MDCX: Split mgcp header pars parsing into a previous step ......................................................................

Patch Set 4:

(1 comment)

File src/libosmo-mgcp/mgcp_protocol.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/39239/comment/b3b90472_372b7ffb?usp=... : PS4, Line 1115: /* Reset conn mode in case it was tweaked through VTY: */

erm having trouble imagining how vty can tweak an incoming MDCX message... […]

Yeah, something else which kinda sucks a bit:

$ ag "->mode" | grep vty src/libosmo-mgcp/mgcp_vty.c:1374: conn->mode = MGCP_CONN_LOOPBACK; src/libosmo-mgcp/mgcp_vty.c:1376: conn->mode = conn->mode_orig;

See VTY command "loop-endpoint <0-64> NAME (0|1)". Again, something I cannot really solve/improve in this patch, too many refactoring already.