Attention is currently required from: daniel, neels.

View Change

1 comment:

• File src/libosmo-mgcp/mgcp_protocol.c:

  • Patch Set #4, Line 1115: /* Reset conn mode in case it was tweaked through VTY: */

    erm having trouble imagining how vty can tweak an incoming MDCX message... […]

    Yeah, something else which kinda sucks a bit:
        
        $ ag "\->mode"  | grep vty
        src/libosmo-mgcp/mgcp_vty.c:1374:		                conn->mode = MGCP_CONN_LOOPBACK;
        src/libosmo-mgcp/mgcp_vty.c:1376:		                conn->mode = conn->mode_orig;
        
        
    See VTY command "loop-endpoint <0-64> NAME (0|1)".
    Again, something I cannot really solve/improve in this patch, too many refactoring already.

To view, visit change 39239. To unsubscribe, or for help writing mail filters, visit settings.