[L] Change in osmo-bts[master]: CSD: implement half-rate modes correctly - gerrit-log

4 Nov 2024

Attention is currently required from: fixeria.

falconia has posted comments on this change by falconia. (
https://gerrit.osmocom.org/c/osmo-bts/+/38553?usp=email )

Change subject: CSD: implement half-rate modes correctly
......................................................................

Patch Set 4:

(4 comments)

Commit Message:

https://gerrit.osmocom.org/c/osmo-bts/+/38553/comment/597d5469_e6fc369b?usp… :
PS2, Line 26: by emitting two RTP packets
            : directly back-to-back for UL, and pulling two RTP packets at a time
            : from the Rx jitter buffer at the needed times for DL.
...
  You are correct: if we were implementing a new E1 BTS,
there would be no other way to handle the pre […] Done

File src/common/l1sap.c:

https://gerrit.osmocom.org/c/osmo-bts/+/38553/comment/cc0083bb_90ec06f7?usp… :
PS2, Line 1493: /* TDMA frame number of burst 'a' % 26 is the table index.
...
  I agree with Mychaela here. It's a well known
constant that is used quite often here and there. Done

https://gerrit.osmocom.org/c/osmo-bts/+/38553/comment/f165ebd3_682357c9?usp… :
PS2, Line 1523: 	if (!sched_tchh_dl_csd_map[fn % 26])
...
  Again, I don't just have the number 26 randomly
floating around in the code. […] Done

https://gerrit.osmocom.org/c/osmo-bts/+/38553/comment/2366f794_08a3e6c8?usp… :
PS2, Line 2045:  * back-to-back every 40 ms on the same frame number, */
...
  If you read my comment carefully, you'll see that
I don't say anything about sending packets "with"  […] Done

-- 
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/38553?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ib35e910df263743cd243f51fb0bd6551ddfcf4c5
Gerrit-Change-Number: 38553
Gerrit-PatchSet: 4
Gerrit-Owner: falconia &lt;falcon(a)freecalypso.org&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-Reviewer: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Attention: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Gerrit-Comment-Date: Mon, 04 Nov 2024 21:43:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: falconia &lt;falcon(a)freecalypso.org&gt;
Comment-In-Reply-To: fixeria &lt;vyanitskiy(a)sysmocom.de&gt;
Comment-In-Reply-To: pespin &lt;pespin(a)sysmocom.de&gt;