laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39842?usp=email ) Change subject: mme: Replace TC_s1ap_setup_wrong_plmn with test with different expectancies ...................................................................... mme: Replace TC_s1ap_setup_wrong_plmn with test with different expectancies This test was written following previous open5gs behavior, which was wrong and updated in https://github.com/open5gs/open5gs/issues/3544. Expect test to trigger a successful S1 setup procedure. Rename the test to reflect the new expectancies. Related: OS#6634 Change-Id: I3aba3d642e3bc70f08b6e0713514fb8906da775d --- M mme/MME_Tests.ttcn M mme/expected-results.xml 2 files changed, 6 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/mme/MME_Tests.ttcn b/mme/MME_Tests.ttcn index cc2e5e9..2192775 100644 --- a/mme/MME_Tests.ttcn +++ b/mme/MME_Tests.ttcn @@ -496,12 +496,13 @@ } } -/* Unsuccessful S1 Setup procedure to MME (wrong PLMN) */ -testcase TC_s1ap_setup_wrong_plmn() runs on MTC_CT { +/* S1 Setup procedure to MME using a Global eNB ID containing unknown/foreign PLMN. + * Related: https://github.com/open5gs/open5gs/issues/3544 */ +testcase TC_s1ap_setup_unknown_global_enb_id_plmn() runs on MTC_CT { var charstring id := testcasename(); f_init_s1ap(id, 1); g_enb_pars[0].global_enb_id.pLMNidentity := '62F224'O; - f_s1ap_setup(0, {misc:=unknown_PLMN}); + f_s1ap_setup(0); } /* Unsuccessful S1 Setup procedure to MME (wrong PLMN) */ @@ -1617,7 +1618,7 @@ } control { - execute( TC_s1ap_setup_wrong_plmn() ); + execute( TC_s1ap_setup_unknown_global_enb_id_plmn() ); execute( TC_s1ap_setup_wrong_tac() ); execute( TC_s1ap_setup() ); execute( TC_s1ap_attach() ); diff --git a/mme/expected-results.xml b/mme/expected-results.xml index 48496a4..370aa0e 100644 --- a/mme/expected-results.xml +++ b/mme/expected-results.xml @@ -1,6 +1,6 @@ <?xml version="1.0"?> <testsuite name='Titan' tests='71' failures='8' errors='0' skipped='0' inconc='0' time='MASKED'> - <testcase classname='MME_Tests' name='TC_s1ap_setup_wrong_plmn' time='MASKED'/> + <testcase classname='MME_Tests' name='TC_s1ap_setup_unknown_global_enb_id_plmn' time='MASKED'/> <testcase classname='MME_Tests' name='TC_s1ap_setup_wrong_tac' time='MASKED'/> <testcase classname='MME_Tests' name='TC_s1ap_setup' time='MASKED'/> <testcase classname='MME_Tests' name='TC_s1ap_attach' time='MASKED'/> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/39842?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3aba3d642e3bc70f08b6e0713514fb8906da775d Gerrit-Change-Number: 39842 Gerrit-PatchSet: 1 Gerrit-Owner: pespin &lt;pespin(a)sysmocom.de&gt; Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel &lt;dwillmann(a)sysmocom.de&gt; Gerrit-Reviewer: fixeria &lt;vyanitskiy(a)sysmocom.de&gt; Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt; Gerrit-Reviewer: lynxis lazus &lt;lynxis(a)fe80.eu&gt;