Attention is currently required from: laforge, laforge.

daniel has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/python/pyosmocom/+/42556?usp=email )

Change subject: tlv: Allow control over comprehension bit in COMPR_TLV_IE ......................................................................

Patch Set 1:

(1 comment)

Patchset:

PS1:

The function already supports a {tag, comprehension} input syntax for the 'tag' argument. […]

I looked at that, but the tag is a property of the (sub-)class and used in the metaclass:

``` python # TS 102 223 Section 8.35 class CApdu(COMPR_TLV_IE, tag=0xA2): _construct = GreedyBytes ```

The metaclass (ComprTlvMeta) constructor __new__ assumes that tag is an int.

The constructor of the actual subclass (e.g. CApdu) does not do anything with a tag variable - even if you passed it.